-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guidelines for incrementing the config part of the version string #104
Comments
Hey @doug-walker, Any particular reasons for not trying to fly closer to SemVer? e.g. additions of new colourspaces and displays are Minor but changes to transforms are Major? |
@KelSolaar , thanks for the feedback. (The above is just a strawman for discussion and so I'm open to changing any of it.) The rationale for incrementing the major version when color spaces are added is that the new config could not be interchanged with the previous one without risk of an error. Regarding changes to the transforms, I think whether it's major or minor would be a judgment call about what actually changed. For example, if it's a small change to an entry in a remote part of a 3d-LUT, maybe that's only a minor / bug-fix type of version increment. |
The working group discussed this during the 2023-08-29 meeting. Here is what I captured as a summary:
|
Here is a first pass for a table as discussed during the meeting:
You can load the table here and continue editing if needed: https://www.tablesgenerator.com/markdown_tables |
The name of the configs contains a string with three versions. For example:
cg-config-v1.0.0_aces-v1.3_ocio-v2.1
. It is self-evident what the ACES and OCIO versions should contain but the guidelines for when to increment the config part have not been documented. The following guidelines are proposed as a strawman for further discussion:Major version increment:
Minor version increment:
Patch version increment:
I'm on the fence about some of these. In many cases it could be a matter of degree (was it a big change or a small change) and so it's difficult to come up with absolutely fixed rules. Therefore, it seems prudent to refer to these as "guidelines" rather than "rules" to indicate that in some cases there will be a judgment call made by the configs working group on how to assign a new version string.
The text was updated successfully, but these errors were encountered: