Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite readme with clearer descriptions #27

Open
gilescope opened this issue Sep 18, 2022 · 3 comments
Open

Rewrite readme with clearer descriptions #27

gilescope opened this issue Sep 18, 2022 · 3 comments

Comments

@gilescope
Copy link

Have been having a go again at https://github.com/InvArch/INV4-Git . Got much further this time.
(btw had to add the wasm32 target manually - that's worth adding into your scripts if possible)

Got up to:
git push origin master (ideally this should be main)

Now I get Enter your private key/seed phrase:. Is this expected? Is this because I'm usign gpg / yubikeys to sign my commits? I did try doing the same with an unsigned commit but it still popped up for me (I set git config commit.gpgsign false for that repo). Obviously it would be great if signed commits just worked - my ubikey should flash when the git push origin master is executed. I do accept that not everyone signs their commits at the moment but crypo is cool.

@arrudagates
Copy link
Member

This is supposed to take your Tinkernet account, as it needs to sign the NFT mint transactions under your account. This authentication flow is also implemented following git standards, if you have a git credential helper set up that stores your credential it will get stored (encrypted with the password you provided on top of whatever encryption your helper of choice uses), and if you don't use a helper to store, it won't get stored.

@gilescope
Copy link
Author

gilescope commented Sep 19, 2022 via email

@arrudagates arrudagates changed the title signed commits / yubikey Rewrite readme with clearer descriptions Sep 19, 2022
@arrudagates
Copy link
Member

Good point, I'm repurposing this issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants