From 1db5bcdaf608361a2694d1fb44cb74b3e8435f5f Mon Sep 17 00:00:00 2001 From: Wang Zihan Date: Tue, 14 Nov 2023 02:40:01 +0800 Subject: [PATCH 1/3] Tweak DG and PPP --- docs/DeveloperGuide.md | 16 +++++++++++++++- docs/team/larrywang0701.md | 7 ++++--- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md index 078c9972072..29512f1e9a1 100644 --- a/docs/DeveloperGuide.md +++ b/docs/DeveloperGuide.md @@ -44,8 +44,10 @@ * [Events feature](#events-feature) * [Overview: Event](#overview--event-) * [Implementing `AddEventCommandParser`](#implementing-addeventcommandparser) + * [Implementing `ListEventCommandParser`](#implementing-listeventcommandparser) * [Implementing `DeleteEventCommandParser`](#implementing-deleteeventcommandparser) * [Implementing `AddEventCommand`](#implementing-addeventcommand) + * [Implementing `ListEventCommand`](#implementing-listeventcommand) * [Implementing `DeleteEventCommand`](#implementing-deleteeventcommand) * [Enhanced help feature](#enhanced-help-feature) * [[Proposed] Undo/redo feature](#proposed-undo-redo-feature) @@ -425,7 +427,7 @@ Simply replace `AddCommandParser` with `DeleteCommandParser`, `AddEventCommandPa ##### Implementing `AddEventCommandParser` -Implements the `Parser` interface, parsing these arguments: +Implements the `Parser` interface, parsing six main arguments: 1. `contactId`: the one-based index of the contact shown in the GUI. 2. `eventName`: the name of the event. 3. `eventStartTime`: the start time of the event. @@ -438,6 +440,18 @@ After that, `contactId` and the `Event` object created are then used to create t For the details of how parsing works, see the section on [Logic Component](#logic-component). +##### Implementing `ListEventCommandParser` +Implements the `Parser` interface, parsing three main arguments: +1. `filterStartTime`: the start time for filtering the events +2. `filterEndTime`: the end time for filtering the events +3. `useAscendingOrder`: should use ascending order when sorting the events? + +`filterStartTime`, `filterEndTime` and `useAscendingOrder` are then used to create the `ListEventCommand` object. + +`filterStartTime` and `filterEndTime` can both be `null` (to disable filtering) or neither be `null`, but can NOT only one of them be `null`. + +For the details of how parsing works, see the section on [Logic Component](#logic-component). + ##### Implementing `DeleteEventCommandParser` Implements the `Parser` interface, parsing two main arguments: 1. `contactId`: the one-based index of the contact shown in the GUI. diff --git a/docs/team/larrywang0701.md b/docs/team/larrywang0701.md index 26c3ad79c8e..785a92506fa 100644 --- a/docs/team/larrywang0701.md +++ b/docs/team/larrywang0701.md @@ -37,10 +37,11 @@ - Wrote the User Stories part in the DG [#10](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/10) - Add details about secondary command parser in DG [#47](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/47/files#diff-1a95edf069a4136e9cb71bee758b0dc86996f6051f0d438ec2c424557de7160b) + - Add details about implementation on `ListEventCommandParser` and `ListEventCommand` - UML diagrams that I made: [#206](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/206) - - - + - + - + - - #### Review/mentoring contributions From faab110a279c5aa5218214d48a01911ce3303d91 Mon Sep 17 00:00:00 2001 From: Wang Zihan Date: Tue, 14 Nov 2023 02:44:19 +0800 Subject: [PATCH 2/3] Tweak PPP --- docs/team/larrywang0701.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/team/larrywang0701.md b/docs/team/larrywang0701.md index 785a92506fa..c37c6855a13 100644 --- a/docs/team/larrywang0701.md +++ b/docs/team/larrywang0701.md @@ -37,7 +37,7 @@ - Wrote the User Stories part in the DG [#10](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/10) - Add details about secondary command parser in DG [#47](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/47/files#diff-1a95edf069a4136e9cb71bee758b0dc86996f6051f0d438ec2c424557de7160b) - - Add details about implementation on `ListEventCommandParser` and `ListEventCommand` + - Add details about implementation on `ListEventCommandParser` and `ListEventCommand` [#206](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/206) [#208](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/208) - UML diagrams that I made: [#206](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/206) - - From b14a6346ca23fd9a22614fb820031d9e30db10dd Mon Sep 17 00:00:00 2001 From: Wang Zihan Date: Tue, 14 Nov 2023 02:50:00 +0800 Subject: [PATCH 3/3] Tewak PPP --- docs/team/larrywang0701.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/team/larrywang0701.md b/docs/team/larrywang0701.md index c37c6855a13..0fef7de786f 100644 --- a/docs/team/larrywang0701.md +++ b/docs/team/larrywang0701.md @@ -51,3 +51,6 @@ - [#69](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/69) - [#163](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/163) - [#168](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/168) + + - #### Contributions beyond the project team + - Reported 6 bugs to other team's product during PE-D