Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D] Edit feature allows for editing for all fields except additional information. #186

Closed
nus-pe-bot opened this issue Oct 30, 2020 · 1 comment
Assignees
Labels
wontfix This will not be worked on

Comments

@nus-pe-bot
Copy link

image.png

Steps to replicate:
edit 1 a/Likes chocolate

It seems as though all other fields can be edited except additional information, it would be good if the edit feature could edit additional details field as well without having to separate it into two other commands. I think you might want to combine the "detail add" and "detail edit" with the edit command! instead.


Labels: severity.Low type.FeatureFlaw
original: kkangs0226/ped#2

@VaishakAnand VaishakAnand self-assigned this Nov 1, 2020
@VaishakAnand VaishakAnand added the wontfix This will not be worked on label Nov 2, 2020
@VaishakAnand
Copy link

Editing details through edit command would make it more difficult, as it would be complicated to find out which detail within the student the user wants to edit, and to get the desired new detail text for the detail. Bringing it out to separate command makes it clearer for the user, and easier for all parties.

Therefore, we won't be implementing this suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants