Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Possible PR] Wildcards ported from outdated script #5

Open
aphix opened this issue Nov 1, 2022 · 1 comment
Open

[Possible PR] Wildcards ported from outdated script #5

aphix opened this issue Nov 1, 2022 · 1 comment

Comments

@aphix
Copy link

aphix commented Nov 1, 2022

Looks like this script didn't bring over the updates I made to the existing wildcard script that handled image grid generation as a final step, fixed seed issues, and added wildcard prompt info to the PNG metadata.

If those aren't something to be handled by extensions anymore then perhaps this can be closed, but otherwise these two commits should be simple enough to port to the new script. Let me know if you'd prefer if I submitted as a PR, or if there was a reason the outdated script was used (these were previously already merged into the jtkelm2 script).

AUTOMATIC1111/stable-diffusion-webui@8969bb4
AUTOMATIC1111/stable-diffusion-webui@5a4a343
(note that the 2nd commit fixes a few issues noticed/mentioned when developing 1st commit)

Thanks,
Aphix

@mnielsendev
Copy link

mnielsendev commented Nov 15, 2022

I'd also like to see this extension caught up to the existing wildcard script. If AUTOMATIC1111 (understandably) doesn't want to maintain this extension on top of everything else then it might be good idea to hand it over to the creator of the original script or whoever wants to update and maintain wildcards.

Edit:
Upon further research, I'm a bit confused. Has the Wildcards extension been superseded by Dynamic Prompts? If so, it might be good if the former were dropped from the WebUI extensions list. Also apologies for any accidental automatic pings if this is indeed a necropost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants