From 792c86144e3093baf0840e570da2bef75275a29e Mon Sep 17 00:00:00 2001 From: surajgoraya Date: Wed, 29 May 2024 15:40:30 -0400 Subject: [PATCH 1/5] build: more changes --- .github/workflows/production.yml | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/.github/workflows/production.yml b/.github/workflows/production.yml index 5890b9b..f86f510 100644 --- a/.github/workflows/production.yml +++ b/.github/workflows/production.yml @@ -56,14 +56,6 @@ jobs: with: node-version: "18" cache: ${{ steps.detect-package-manager.outputs.manager }} - - name: Setup Pages - uses: actions/configure-pages@v3 - # with: - # Automatically inject basePath in your Next.js configuration file and disable - # server side image optimization (https://nextjs.org/docs/api-reference/next/image#unoptimized). - # - # You may remove this line if you want to manage the configuration yourself. - # static_site_generator: next - name: Restore cache uses: actions/cache@v3 with: @@ -79,8 +71,9 @@ jobs: - name: Build with Next.js run: ${{ steps.detect-package-manager.outputs.runner }} next build - name: Upload artifact - uses: actions/upload-pages-artifact@v2 + uses: actions/upload-artifact@v4 with: + name: 'assets-prod-upload' path: ./out # Deployment job @@ -94,6 +87,8 @@ jobs: steps: - name: 🌆 Grab Artifact uses: actions/download-artifact@v4 + with: + name: 'assets-prod-upload' - name: Display structure of downloaded files run: ls -R - name: 📂 Upload Files From 8d1a180d47de56fbfdf5a13156c541b0a4359fe7 Mon Sep 17 00:00:00 2001 From: surajgoraya Date: Wed, 29 May 2024 15:48:14 -0400 Subject: [PATCH 2/5] build: out dir not needed --- .github/workflows/production.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/production.yml b/.github/workflows/production.yml index 97c668c..537fb82 100644 --- a/.github/workflows/production.yml +++ b/.github/workflows/production.yml @@ -98,8 +98,6 @@ jobs: username: ${{secrets.username}} password: ${{ secrets.password }} dry-run: true - local-dir: ./out/ - log-level: verbose exclude: | **/.git* **/.git*/** From a4e6d77e2406f47070d2fb5c0575e1172af7bb9b Mon Sep 17 00:00:00 2001 From: surajgoraya Date: Wed, 29 May 2024 15:53:39 -0400 Subject: [PATCH 3/5] build: im scared --- .github/workflows/production.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/production.yml b/.github/workflows/production.yml index 537fb82..5eaabfb 100644 --- a/.github/workflows/production.yml +++ b/.github/workflows/production.yml @@ -97,7 +97,7 @@ jobs: server: ${{secrets.server}} username: ${{secrets.username}} password: ${{ secrets.password }} - dry-run: true + # dry-run: true exclude: | **/.git* **/.git*/** @@ -106,3 +106,5 @@ jobs: **/cgi-bin/** .ftpquota .htaccess + - name: Display Changes + run: cat ./.ftp-deploy-sync-state.json From d298b8aab7f02509ab26b8d42ed830dd00aad6c9 Mon Sep 17 00:00:00 2001 From: surajgoraya Date: Wed, 29 May 2024 15:57:38 -0400 Subject: [PATCH 4/5] build: :rotating_light: WHOOPS github env is wrong --- .github/workflows/production.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/production.yml b/.github/workflows/production.yml index 5eaabfb..b60ed91 100644 --- a/.github/workflows/production.yml +++ b/.github/workflows/production.yml @@ -29,8 +29,6 @@ jobs: build: name: 🌇 Build runs-on: ubuntu-latest - env: - NEXT_PUBLIC_IN_GITHUB_ACTIONS: true steps: - name: Checkout uses: actions/checkout@v3 From 459606459e4fc5650ae7a428a86d1ce259daa9f1 Mon Sep 17 00:00:00 2001 From: surajgoraya Date: Wed, 29 May 2024 16:02:34 -0400 Subject: [PATCH 5/5] build: im so scared --- next.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/next.config.js b/next.config.js index e898991..6315ec4 100644 --- a/next.config.js +++ b/next.config.js @@ -8,7 +8,7 @@ * check for that. */ -const _IN_GH_ACTIONS = process.env.GITHUB_ACTIONS || false; +const _IN_GH_ACTIONS = process.env.NEXT_PUBLIC_IN_GITHUB_ACTIONS || false; console.log('GITHUB ACTION DETECTED?: ', _IN_GH_ACTIONS); const _REPO = 'assets2024';