Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anyone know why previews are sometime broken? #76

Open
jonfroehlich opened this issue Aug 15, 2022 · 3 comments
Open

Anyone know why previews are sometime broken? #76

jonfroehlich opened this issue Aug 15, 2022 · 3 comments

Comments

@jonfroehlich
Copy link
Collaborator

Generally, they've worked well but here is a failure case:

image

https://twitter.com/jonfroehlich/status/1559244487884677121?s=20&t=J3gjiNT0lqcz1Cz7Zv7VXw

Is there something about how we formatted the HTML/CSS on the accepted-papers.html page to break the auto-generated html preview

@jayhersk
Copy link
Collaborator

That's odd. Checking that page here: https://socialsharepreview.com/?url=https://assets22.sigaccess.org/accepted-papers.html

It does look like we have all the default metadata set, but twitter might use some specific properties depending on the platform? I'll look into it.

For example, for me on web it looks mostly normal (the og:image shows up but it's missing the page title)
Screen Shot 2022-08-26 at 1 34 44 PM

@jayhersk
Copy link
Collaborator

Okay I think I fixed this for the accepted papers page: https://socialsharepreview.com/?url=https://assets-conference.github.io/assets2022/accepted-papers.html

I can add it to the rest of the pages too, but wondering if we might want to add a different preview image aside from the logo? Maybe something like:

test

Would need to find something with the correct ratio though (1200 x 630)

@EdigaHe
Copy link
Collaborator

EdigaHe commented Oct 16, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants