Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Subscriptions feature #1776

Merged
merged 8 commits into from
Sep 1, 2023
Merged

Remove the Subscriptions feature #1776

merged 8 commits into from
Sep 1, 2023

Conversation

jtherrmann
Copy link
Contributor

@jtherrmann jtherrmann commented Aug 17, 2023

Overview

I confirmed that each of the following commands shows no output:

# finds all tracked filenames containing "subscription" (case-insensitive)
git ls-tree -r remove-subscriptions --name-only | grep -i subscription

# finds all occurrences of "subscription" (case-insensitive) in tracked files other than the Changelog
git grep -i subscription | grep -v CHANGELOG

We expect these resources to get deleted:

  • subscription manager and worker lambdas
  • subscriptions dynamodb table
  • subscription_id parameter for get jobs api endpoint
  • subscriptions api endpoints
  • subscriptions-related api schemas

Before merging to test

  • Changelog entry.

Verify changes in a sandbox deployment:

  • Create a new sandbox deployment (branch off of develop).
  • Set user quota for myself.
  • Create some subscriptions in the sandbox and let them generate some products.
  • Merge remove-subscriptions into subscriptions-removal-sandbox and verify that all expected resources get deleted
  • Why does Swagger UI show INVALID for API schema? (see bottom-right corner of page)
  • Manually remove the subscription_id field from the Jobs table.

After merging to test

  • Verify that all expected resources get deleted
  • Verify that Swagger UI shows VALID for API schema (see bottom-right corner of page)
  • Manually remove the subscription_id field from the Jobs table.

@jtherrmann jtherrmann marked this pull request as ready for review September 1, 2023 19:49
@jtherrmann jtherrmann requested a review from a team as a code owner September 1, 2023 19:49
@jtherrmann jtherrmann merged commit 1999d6d into develop Sep 1, 2023
12 checks passed
@jtherrmann jtherrmann deleted the remove-subscriptions branch September 1, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants