[Breaking Change] Initial implementation of Collector Refactor #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have have multiple `trace` instruments that do not match the description and therefore are moved to have a more suitably named hierarchy.
Update `get_trace` to `get_data` to better reflect the purpose. The return type of said method will be a `CollectorOutput` object will contain one or more `CollectorOutputEntry` objects which will be used to provide the `path`and `path_kind` attributes to indicate the path to the obtained output and it's type (currently a "file" or "directory") respectively.
Update the interface to make use of the collector interface. Notable changes are the removal of the `output_path` path provided on initialisation which will now be provided by the dedicated `set_output` method.
marcbonnici
changed the title
This was referenced Jan 2, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
TraceCollectoras per #383.