-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AArch64 Big Endian Variants using FVP models #554
Conversation
QEMU's doesn't have big-endian support in the release binaries. so need to use FVPs to test those libraries.
Similar comment to #553: should we move the expansion of library variants inside the |
I had changes in CMakeLists.txt to use the correct bootcode. This is no longer needed as it is already adding through a different patch: ARM-software#567
Multilib flags do not need to have -mbig-endian. Big endian variants can be differentiated with the target aarch64_be. if the commandline options contain aarch64 and -mbig-endian, clang convert the target into aarch64_be already so that case works in that way. If the multilib flags contain -mbig-endian, commandline options just contain target=aarch64_be does not work, looks like multiib system insist on having -mbig-endian in the commandline.
Yeah there is a plan to do this as a long term solution when you have more library variants work with big-endian and strict-align. As a starting point, we will start adding separately now. |
Add -Dtest-machine=${TEST_EXECUTOR} to use the correct bootcode. Remove tabs
Remove -Dtest-machine=${TEST_EXECUTOR} as it is already been done through the patch: ARM-software#574
This patch add new aarch64 big endian library variants.
QEMU's doesn't have big-endian support in the release binaries. so need to use FVPs to test those libraries.