Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offload ark-cli storage Subcommand Methods to fs-storage Crate #73

Open
2 tasks
tareknaser opened this issue Jun 15, 2024 · 0 comments
Open
2 tasks

Offload ark-cli storage Subcommand Methods to fs-storage Crate #73

tareknaser opened this issue Jun 15, 2024 · 0 comments
Assignees

Comments

@tareknaser
Copy link
Collaborator

Description

Currently, ark-cli storage subcommand implements its own storage handling methods for different storage types, specifically:

  • File
  • Folder

For each storage type, ark-cli includes methods to:

  • Load storage from disk
  • Read storage
  • Append to storage
  • Overwrite storage

ark-cli exposes CLI commands to call these methods from the command line.

For better modularity, we should offload these operations to another crate within ark-rust workspace, potentially fs-storage.
ark-cli crate should then only have CLI command structs to gather parameters from the user, perform minimal preprocessing (if needed), and pass these to the methods in fs-storage. This will allow better separation of concerns, making the codebase easier to manage and extend.

Tasks

  • Implement the storage handling methods (loading, reading, appending, overwriting) in fs-storage crate.
  • Modify the ark-cli crate to use the fs-storage crate for all storage operations.

Related conversation: #67 (comment)

@tareknaser tareknaser self-assigned this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant