Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for fs-index Crate #31

Closed
9 tasks done
tareknaser opened this issue Apr 19, 2024 · 2 comments
Closed
9 tasks done

Enhancements for fs-index Crate #31

tareknaser opened this issue Apr 19, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@tareknaser
Copy link
Collaborator

tareknaser commented Apr 19, 2024

This is a tracking issue for brainstorming ideas to enhance fs-index crate

The difference between watch_index and ark-cli monitor is that watch_index uses notify to only update the index when a file system change is detected, as opposed to rebuilding the index from scratch on a time interval.

  • Create examples folder:
    • Include one example showing the normal scenario of creating a new index in a specified path and using the API.
    • Include another example showcasing index watch functionality.
  • Benchmark the performance of resource indexing queries and operations as outlined in issue Enhance Benchmarking Suite and Add Profiling Support #30.
  • Ensure that modules are private and only necessary structs and methods are exported.
  • Place unit tests in a separate file instead of index.rs.
  • Implement a custom Serialize implementation for ResourceIndex where double mappings are not written.
@tareknaser
Copy link
Collaborator Author

@kirillt

I think we can safely close this issue now. Is there anything else related to this you'd like to suggest we do first?

@kirillt
Copy link
Member

kirillt commented Nov 26, 2024

It seems that all sub-issues have been addressed.

Great work, thanks!

@kirillt kirillt closed this as completed Nov 26, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Development Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants