Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RootPickerDialog and prohibit adding a new root if there is already a root inside #68

Open
mdrlzy opened this issue Feb 15, 2024 · 1 comment
Open

Move RootPickerDialog and prohibit adding a new root if there is already a root inside #68

mdrlzy opened this issue Feb 15, 2024 · 1 comment
Assignees
@tuancoltech

Comments

@mdrlzy
Copy link
Member

mdrlzy commented Feb 15, 2024 •
edited by kirillt
Loading

Move RootPickerDialogFragment here from Navigator
The functionality of the RootPickerDialogFragment and the ArkFilePickerViewModel.pinFile() are the same. In fact, we can add root/favorite from two different places. We need to reuse the general logic and prohibit adding root if there is already a root inside.
We also need to prohibit adding device root as ARK root.
@tuancoltech tuancoltech self-assigned this Feb 15, 2024
This was referenced Feb 17, 2024
Closed
Closed
@kirillt
Copy link
Member

kirillt commented Mar 6, 2024 •
edited
Loading

We also need to prohibit adding device root as ark root.

I'm thinking about this again and it seems there could be scenarios when it's ok, e.g. SD card if user doesn't have a lot of data on it. Do you think we should implement it?

@kirillt kirillt moved this to Todo in Development Mar 6, 2024
tuancoltech added a commit that referenced this issue Mar 18, 2024
@tuancoltech
Prohibit creating nested roots: #68
492b448
@tuancoltech tuancoltech mentioned this issue Mar 18, 2024
Merged
tuancoltech added a commit that referenced this issue Mar 18, 2024
@tuancoltech
Prohibit creating nested roots: #68
44f246b
tuancoltech added a commit that referenced this issue Mar 23, 2024
@tuancoltech
Prohibit creating nested roots: #68
39c765e
tuancoltech added a commit to ARK-Builders/ARK-Navigator that referenced this issue Mar 24, 2024
@tuancoltech
Remove duplicated business logic between Navigator and filepicker mod…
1b7f58c 
…ule: ARK-Builders/ark-android#68
@tuancoltech tuancoltech mentioned this issue Mar 24, 2024
Open
tuancoltech added a commit that referenced this issue Mar 24, 2024
@tuancoltech
Prohibit creating nested roots: #68
2416977
tuancoltech added a commit that referenced this issue Mar 24, 2024
@tuancoltech
Prohibit creating nested roots: #68
b63d055
tuancoltech added a commit that referenced this issue Mar 27, 2024
@tuancoltech
Prohibit creating nested roots: #68
235daea
@kirillt kirillt moved this from Todo to In Progress in Development Mar 31, 2024
@kirillt kirillt moved this from In Progress to Todo in Development Apr 3, 2024
tuancoltech added a commit that referenced this issue Aug 8, 2024
@tuancoltech
Prohibit creating nested roots: #68
b7fb1e6
tuancoltech added a commit that referenced this issue Nov 11, 2024
@tuancoltech
Prohibit creating nested roots: #68
a445b7b
@mdrlzy mdrlzy mentioned this issue Dec 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tuancoltech tuancoltech

Labels
None yet
Projects
Development
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kirillt @tuancoltech @mdrlzy