Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong metadata json for links #59

Open
mdrlzy opened this issue Mar 6, 2023 · 3 comments
Open

Wrong metadata json for links #59

mdrlzy opened this issue Mar 6, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@mdrlzy
Copy link
Member

mdrlzy commented Mar 6, 2023

code:LINK field is missing in kind json file for links

@kirillt kirillt added the bug Something isn't working label Mar 15, 2023
@mdrlzy
Copy link
Member Author

mdrlzy commented Aug 5, 2023

code changed to kind

@kirillt kirillt self-assigned this Nov 19, 2023
@kirillt kirillt removed their assignment Dec 20, 2023
@kirillt
Copy link
Member

kirillt commented Jan 11, 2024

Also, this JSON in cache/metadata is incorrect:

{
  "title": "Яндекс",
  "description": "Найдётся всё",
  "url": "https://ya.ru",
  "image": "https://yastatic.net/s3/home-static/_/43/43e341fd2770891523066b0f25051a7b.png",
  "object_type": "website",
  "locale": "ru_RU"
}
  • We may keep automatic title in metadata, but we should use it somehow (as a secondary title in addition to what the user specified? as a default value?)
  • Same with description
  • We must not store url in metadata, that's what the resource contains
  • Are image, object_type and locale fields really useful?

@kirillt
Copy link
Member

kirillt commented Feb 13, 2024

Complete this first:

@kirillt kirillt transferred this issue from ARK-Builders/arklib Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants