Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use all pairs for conversions #14

Open
kirillt opened this issue Nov 11, 2022 · 0 comments
Open

Use all pairs for conversions #14

kirillt opened this issue Nov 11, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@kirillt
Copy link
Member

kirillt commented Nov 11, 2022

https://github.com/ARK-Builders/ARK-Rate/pull/13/files/3ab38d7d0f286ad24a388faa69d251fcff49dfb7#diff-3356bc53a97bf9b7871002de7206cd61868a871759da3c49c1d29fa3dfba4c52R40

When we convert crypto assets, we use only those pairs, which have USD as one side of the pair. In other words, we always convert one crypto token to another via USDT. We could achieve more realistic conversion if we store all pairs in memory and first attempt to find direct match, before converting via USDT as a fallback.

Bonus points for advanced routing, e.g. ATOM -> DOT -> BTC.
@kirillt kirillt added the enhancement New feature or request label Nov 11, 2022
@kirillt kirillt mentioned this issue Nov 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kirillt