Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Refactor to Utilize SvelteKit Routing #31

Open
alvinosh opened this issue Apr 18, 2024 · 0 comments
Open

Small Refactor to Utilize SvelteKit Routing #31

alvinosh opened this issue Apr 18, 2024 · 0 comments

Comments

@alvinosh
Copy link
Collaborator

Description

Currently we are switching between the gallery route and the image view via svelte stores, this adds too much global state and makes it difficult to expand and add more files.

Example

Checks like this are problematic

<div class:hidden={!$galleryStore.galleryView}>

Solution

We can add new routes to the application, such as /view?image=... or some sort of other implementation that is compatible with sveltekit and tauri
https://kit.svelte.dev/docs/routing

kirillt pushed a commit that referenced this issue May 29, 2024
* Add Image Deletion
* Remove most of global state
* Make functions pure
* Switch to NPM
---------

Co-authored-by: Kawsar Ahmed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant