Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt-cmd validate does not properly validate tag manifests if the BagIt profile says tag manifests are optional #3

Open
diamondap opened this issue Nov 9, 2023 · 0 comments

Comments

@diamondap
Copy link
Member

What Happens

The APTrust BagIt profile allows tag manifests with md5 and sha256 algorithms, but it does not require any tag manifests. If a bag includes a tag manifest with invalid checksums, the apt-cmd validator will say the bag is valid.

What Should Happen

The validator should compare the checksums in the tag manifest to the actual checksums of the tag files.

Steps To Reproduce

  1. Change into the directory testbags/aptrust.
  2. Run this command to validate bad-tag-manifests.tar with the APTrust profile: apt-cmd bag validate -p aptrust bad-tag-manifests.tar

Expected: The bag fails validation with messages about tag files not matching checksums in tagmanifest-md5.txt.

Actual: The validator says Bag is valid according to aptrust profile.

The validator in preservation services does catch these errors, so let's use that as a reference when fixing this.

diamondap added a commit that referenced this issue Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant