Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (and merge) Dockerfiles, adds a CI job for building and uploading docker images #22

Merged
merged 11 commits into from
Nov 18, 2024

Conversation

guillaumedsde
Copy link
Contributor

@guillaumedsde guillaumedsde commented Nov 17, 2024

📝 Description

Hello 👋

This PR corrects an issue with the repository's Dockerfiles: the final images don't include the glibc dependency due to them using the slim variant of the debian image as the base.
The consequence of this is that the lidis/r binaries crash on startup when running the docker images built from this repository's Dockerfiles, moreover no docker image is published on the docker hub.

Note that it might be desirable to squash the commits when merging, the commit history is ok, but not ideal

✔️ Changelog

The PR addresses this by:

  • rewriting the Dockerfiles into a single multi-stage Dockerfile (one stage for the send binary, another for the receive binary)
  • using one of Google's "distroless" docker image as the base for the final images.
  • switching to a non-root user for the final docker images
  • adding a CI job for building, tagging and publishing the final two docker images (send/receive) to the dockerhub

🥼 Tests

Note that I have tested the Github action logic for build, tagging and pushing the docker images but in my own fork (since I don't have access to this repo's CI). During my tests (which consisted of building and uploading the image's to my repo's github registry) everything worked as exepcted.

@guillaumedsde guillaumedsde marked this pull request as ready for review November 17, 2024 14:32
@gmolveau-anssi gmolveau-anssi merged commit 7337786 into ANSSI-FR:master Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants