Fix (and merge) Dockerfiles, adds a CI job for building and uploading docker images #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Hello 👋
This PR corrects an issue with the repository's Dockerfiles: the final images don't include the glibc dependency due to them using the slim variant of the debian image as the base.
The consequence of this is that the lidis/r binaries crash on startup when running the docker images built from this repository's Dockerfiles, moreover no docker image is published on the docker hub.
Note that it might be desirable to squash the commits when merging, the commit history is ok, but not ideal
✔️ Changelog
The PR addresses this by:
🥼 Tests
Note that I have tested the Github action logic for build, tagging and pushing the docker images but in my own fork (since I don't have access to this repo's CI). During my tests (which consisted of building and uploading the image's to my repo's github registry) everything worked as exepcted.