From 83485bac9ffb7df61dd168e5ef5fcf23f8b2ea5e Mon Sep 17 00:00:00 2001 From: Michael Zingale Date: Wed, 29 Nov 2023 10:53:05 -0500 Subject: [PATCH 1/3] ignore angular_momentum_z in rad CI for some reason we get -0 on github but 0 locally must be a lib difference (hypre?) somewhere --- .github/workflows/rad-compare.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rad-compare.yml b/.github/workflows/rad-compare.yml index b123c972c8..922efd27c2 100644 --- a/.github/workflows/rad-compare.yml +++ b/.github/workflows/rad-compare.yml @@ -53,5 +53,5 @@ jobs: run: | cd Exec/radiation_tests/Rad2Tshock ../../../external/amrex/Tools/Plotfile/fextrema.gnu.ex plt_00025 > fextrema.out - diff fextrema.out ci-benchmarks/Rad2TShock-1d.out + diff -I "^angular_momentum_z" fextrema.out ci-benchmarks/Rad2TShock-1d.out From a774382c06c00eb1cacab107b7828fabbdfcda1d Mon Sep 17 00:00:00 2001 From: Michael Zingale Date: Wed, 29 Nov 2023 11:03:16 -0500 Subject: [PATCH 2/3] whitespac --- .github/workflows/rad-compare.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rad-compare.yml b/.github/workflows/rad-compare.yml index 922efd27c2..04f1ecaad1 100644 --- a/.github/workflows/rad-compare.yml +++ b/.github/workflows/rad-compare.yml @@ -53,5 +53,5 @@ jobs: run: | cd Exec/radiation_tests/Rad2Tshock ../../../external/amrex/Tools/Plotfile/fextrema.gnu.ex plt_00025 > fextrema.out - diff -I "^angular_momentum_z" fextrema.out ci-benchmarks/Rad2TShock-1d.out + diff -I "^ angular_momentum_z" fextrema.out ci-benchmarks/Rad2TShock-1d.out From 57d68290a7b10989e132fecb81a098d0cabb424a Mon Sep 17 00:00:00 2001 From: Michael Zingale Date: Thu, 30 Nov 2023 08:01:43 -0500 Subject: [PATCH 3/3] the diff was due to fextrema --- .github/workflows/rad-compare.yml | 2 +- Exec/radiation_tests/Rad2Tshock/ci-benchmarks/Rad2TShock-1d.out | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/rad-compare.yml b/.github/workflows/rad-compare.yml index 04f1ecaad1..b123c972c8 100644 --- a/.github/workflows/rad-compare.yml +++ b/.github/workflows/rad-compare.yml @@ -53,5 +53,5 @@ jobs: run: | cd Exec/radiation_tests/Rad2Tshock ../../../external/amrex/Tools/Plotfile/fextrema.gnu.ex plt_00025 > fextrema.out - diff -I "^ angular_momentum_z" fextrema.out ci-benchmarks/Rad2TShock-1d.out + diff fextrema.out ci-benchmarks/Rad2TShock-1d.out diff --git a/Exec/radiation_tests/Rad2Tshock/ci-benchmarks/Rad2TShock-1d.out b/Exec/radiation_tests/Rad2Tshock/ci-benchmarks/Rad2TShock-1d.out index 4507245d57..c4b21ef48f 100644 --- a/Exec/radiation_tests/Rad2Tshock/ci-benchmarks/Rad2TShock-1d.out +++ b/Exec/radiation_tests/Rad2Tshock/ci-benchmarks/Rad2TShock-1d.out @@ -37,5 +37,5 @@ magmom 1.2327065163e-07 1.4587103381e-07 angular_momentum_x 0 0 angular_momentum_y 0 0 - angular_momentum_z 0 0 + angular_momentum_z -0 -0