-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2D spherical geometry #2927
Comments
I think also update mom_flux_has_p and related stuff |
This was referenced Sep 8, 2024
5 tasks
5 tasks
zingale
pushed a commit
that referenced
this issue
Sep 16, 2024
This is to address issue #2927 . I updated mom_flux_has_p to work with theta direction in 2d spherical. Also update places where it is used. I think it should just work in riemann_solver and HLL_solver, so nothing is changed there. For Castro_ctu_hydro.cpp and Castro_mol_hydro.cpp I will need to include ptheta just like pradial, so I'll do that in a separate pr to address that separately. I'll also address trans.cpp separately when I do the transverse flux pr
5 tasks
also need to modify cfl_violation/timestep constraint since in spherical2d dy is just dtheta but we want physical length , so rdtheta, when checking and determining timestep |
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We want to add 2D spherical geometry$(r, \theta)$ on the grid with axisymmetry in $\phi$ .
The following tasks need to be done:
Castro/Source/sources/Castro_geom.cpp
to have the geometric terms (done in add geometric source terms for 2D spherical geometry #2955)Castro_util.H
) to have the same factors (done in update local area and volume calculations for 2D spherical geometry #2953)mom_flux_has_p
(done in update mom_flux_has_p to address with 2D spherical #2958)ptheta
flux register analogous to thepradial
one (done in add P_theta flux register and scale pressure using area and volume #2960)The text was updated successfully, but these errors were encountered: