Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative include of files inside <plugins> starts from wrong directory #1180

Closed
Zehvogel opened this issue Oct 17, 2023 · 4 comments
Closed
Labels
bug Fixed Problem is solved Testing Waiting for caller Waiting for issue opener to respond to question

Comments

@Zehvogel
Copy link
Contributor

It looks like includes like this:

        <plugins>
                <include ref="OpenDataDetectorPlugins.xml" />
        </plugins>

do not start their path relative to the file containing this inclusion, but from the current directory from which whichever dd4hep using tool was executed.

For instance, building this version of the opendatadetector and then doing

 . build/this_odd.sh
teveDisplay xml/OpenDataDetector.xml

results in

XercesC          FATAL +++ FATAL Error at file "", Line 0 Column: 0 Message:unable to open primary document entity '/home/lreichen/work/acts/OpenDataDetector/OpenDataDetectorPlugins.xml'

while the path of the file should be [...]/OpenDataDetector/xml/OpenDataDetectorPlugins.xml

@Zehvogel Zehvogel added the bug label Oct 17, 2023
@MarkusFrankATcernch
Copy link
Contributor

MarkusFrankATcernch commented Oct 18, 2023

Just for clarification:
This behavior is only for includes in <plugins/> tags ?

[Sorry, I did not notice before that anything between <...> is not displayed]

@Zehvogel
Copy link
Contributor Author

As far as I can tell yes, e.g. all the other include statements here work flawlessly

@MarkusFrankATcernch
Copy link
Contributor

Once you have checked that this issue is fixed by PR 1181, please close the issue.

@Zehvogel
Copy link
Contributor Author

Yes #1181 fixes my issue, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixed Problem is solved Testing Waiting for caller Waiting for issue opener to respond to question
Projects
None yet
Development

No branches or pull requests

2 participants