Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cached_download deprecated in huggingface_hub 26.0 #124

Open
parambole opened this issue Oct 21, 2024 · 3 comments
Open

cached_download deprecated in huggingface_hub 26.0 #124

parambole opened this issue Oct 21, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@parambole
Copy link
Collaborator

from huggingface_hub import HfFolder, cached_download, hf_hub_download, model_info
Uses cached_download which is causing the following error

ImportError: cannot import name 'cached_download' from 'huggingface_hub' (/usr/local/lib/python3.10/site-packages/huggingface_hub/__init__.py)

@parambole
Copy link
Collaborator Author

@entrpn IMO we can

  1. Use hf_hub_download which is now the recommended approach
  2. Pin the version to <26.0 if we still want to keep using cached_download

@entrpn
Copy link
Collaborator

entrpn commented Oct 21, 2024

Let's pin the version for now as a short term solution and revisit this in the future. Thanks for the PR.

@parambole
Copy link
Collaborator Author

I am going to keep this open till then for tracking purpose as mentioned ideally we can just use hf_hub_download it would require some refactoring from the cached_download as it takes different arguments.

@parambole parambole added the good first issue Good for newcomers label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants