Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] : Return list of available .asd channels #75

Open
MaxGamill-Sheffield opened this issue Nov 13, 2024 · 1 comment
Open

[feature] : Return list of available .asd channels #75

MaxGamill-Sheffield opened this issue Nov 13, 2024 · 1 comment
Labels
enhancement New feature or request v0.0.4

Comments

@MaxGamill-Sheffield
Copy link
Collaborator

Is your feature request related to a problem?

When you've typed in the wrong channel name or it has a typo, it would eb preferable if a list of found channel names could be returned.

Describe the solution you would like.

Something akin to the following which is returned for the wrong channel in ..spm

[minicircle] : dosfbipqeb not in .spm channel list: ['Height Sensor', 'Peak Force Error', 'DMTModulus', 'LogDMTModulus', 'Adhesion', 'Deformation', 'Dissipation', 'Height']

Describe the alternatives you have considered.

Written in the TopoStats issues before AFMReader:
Trying to process a ASD file it was found that it did not have the existing set of channels that we are aware of.

They were instead listed as...

  • 0
  • 20564
  • 21061

Whilst we can add these as possible validated channels for the .asd file format it points to/suggests a wider problem in so much as there may be file specifications in use in the wild that we are not aware of.

To which end attempting to obtain a comprehensive sample of target file formats currently in use and that have been produced in the past would be beneficial so that we can enhance the channels that are supported.

This has scope for being compounded further as hardware manufacturers may change or modify their file specifications.


Would a potential solution be to say if no height channel is found it just
tries to process the first channel in the data?

Sample Image

No response

Additional context

No response

@MaxGamill-Sheffield MaxGamill-Sheffield added the enhancement New feature or request label Nov 13, 2024
@ns-rse ns-rse added the v0.0.4 label Dec 16, 2024
@ns-rse
Copy link
Collaborator

ns-rse commented Dec 16, 2024

Likely fit in at line AFMReader/asd.pyL248

The mentioned TopoStats issue that is quoted is issue #422.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v0.0.4
Projects
None yet
Development

No branches or pull requests

2 participants