Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to rename and sort trades and to add notes to them #472

Open
aruku opened this issue Jun 26, 2019 · 3 comments
Open

Ability to rename and sort trades and to add notes to them #472

aruku opened this issue Jun 26, 2019 · 3 comments

Comments

@aruku
Copy link

aruku commented Jun 26, 2019

I have a long list of trades and I keep updating them, and I realized it would be a huge improvement if I could rename a trade instead of loading it, saving it with another name, and then deleting the old one.
Also, allowing to sort the list by date or name when loading an existing one, and adding notes to trades (for example, to indicate the language of cards) would be awesome.

@AEFeinstein
Copy link
Owner

I have a long list of trades and I keep updating them, and I realized it would be a huge improvement if I could rename a trade instead of loading it, saving it with another name, and then deleting the old one.

This is what the "Save Trade As" is for, which you've figured out. Because there is a way to do what you want, even if it takes more clicks than you want, and my time is limited, I most likely won't add a "Rename" button.

Also, allowing to sort the list by date or name when loading an existing one

This is more interesting. How would propose doing the UI for this?

and adding notes to trades (for example, to indicate the language of cards) would be awesome.

This is also interesting, and pretty straightforward. I'll consider it.

@aruku
Copy link
Author

aruku commented Jun 30, 2019

I have a long list of trades and I keep updating them, and I realized it would be a huge improvement if I could rename a trade instead of loading it, saving it with another name, and then deleting the old one.

This is what the "Save Trade As" is for, which you've figured out. Because there is a way to do what you want, even if it takes more clicks than you want, and my time is limited, I most likely won't add a "Rename" button.

Cool; I might attempt to do it myself as a way to get into Android development.

Also, allowing to sort the list by date or name when loading an existing one

This is more interesting. How would propose doing the UI for this?

I don't know anything about designing/writing Android UIs, but I can't think of any element to include in the dialog itself. So maybe a sorting option in the trades screen menu (although that may get users confused with the sorting option for the contents of the trade), or in the general settings menu.

and adding notes to trades (for example, to indicate the language of cards) would be awesome.

This is also interesting, and pretty straightforward. I'll consider it.

Thank you for your attention and hard work!

@AEFeinstein
Copy link
Owner

You're more than welcome to fork MTG Familiar and work on features you'd like. I recommend running them by me first, since that increases the odds your changes get merged back. Renaming a trade is simple enough. If you do that, you might as well add the same button in the deck builder too.

Designing a good UI is hard. If you keep on cramming in features, you end up with something like this:
Swiss Army Knife
I still like the idea of sorting trades in the loading dialog, I'm just not sure the UI complexity is worth it in the trade screen menu. Putting it in general settings is simpler, but disjoint, and not very good for changing the sort order on the fly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants