Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize geoid url variable #100

Open
matt-bo-29 opened this issue Jul 31, 2024 · 1 comment
Open

Externalize geoid url variable #100

matt-bo-29 opened this issue Jul 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@matt-bo-29
Copy link

Hello!

Can we consider to externalize the hardcoded parameter 'ARIA_GEOIDS' ?
It will be helpfull in order to change the url without code modification (if the link does not respond for example). We could imaging to place a link to local geoid files for example.

import os 
ARIA_GEOIDS = os.environ.get('ARIA_GEOIDS', 'https://aria-geoid.s3.us-west-2.amazonaws.com')
GEOID_PATHS_AGI = {
    'geoid_18': f'{DATA_PATH}/geoid_18.tif',
    'egm_08': f'{ARIA_GEOIDS}/egm08_25.tif',
    'egm_96': f'{DATA_PATH}/egm96_15.gtx',
}
@matt-bo-29 matt-bo-29 added the enhancement New feature or request label Jul 31, 2024
@cmarshak
Copy link
Collaborator

I think this is a good idea - we could add a keyword argument to the main stitcher routine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants