Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to python 3.10 and ISCE>=2.6.2 #97

Open
cmarshak opened this issue Feb 1, 2023 · 3 comments
Open

Update to python 3.10 and ISCE>=2.6.2 #97

cmarshak opened this issue Feb 1, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@cmarshak
Copy link
Collaborator

cmarshak commented Feb 1, 2023

Is your feature request related to a problem? Please describe.
Use 3.10 as ISCE2 has been updated: isce-framework/isce2#459 (comment)

Describe the solution you'd like
Make sure builds work

@cmarshak cmarshak added the enhancement New feature or request label Feb 1, 2023
@dbekaert
Copy link
Collaborator

dbekaert commented Feb 2, 2023

Before making such an upgrade, ensure that there has not been any changes to topsApp that changes the quality of our product. There is no end-end testing on ISCE2 and we should ensure there have not been any bugs introduced.

Good practice would be to freeze versions and confirm against a golden dataset.

@cmarshak cmarshak changed the title Update to 3.10 Update to python 3.10 and ISCE>=2.6.2 Feb 2, 2023
@cmarshak
Copy link
Collaborator Author

cmarshak commented Feb 2, 2023

Well, after updating my environment to use the newest ISCE2, I found myself having issues and so agree about haphazard updates.

We will have to fix ISCE2 temporarily and work towards this.

What currently works for me is

isce2==2.6.1
scipy<1.10
numpy<1.24

@cmarshak
Copy link
Collaborator Author

cmarshak commented Feb 2, 2023

Also a good reason to start investing time to have some basic integration tests (with golden datasets) as we mature our dataset and workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants