-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): make containers multi-arch #343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature
New feature or request
github_actions
Pull requests that update GitHub Actions code
python
Pull requests that update Python code
labels
Sep 25, 2024
AtomicFS
force-pushed
the
feat/multi-arch-docker
branch
5 times, most recently
from
September 30, 2024 08:55
434ec0a
to
992d9d5
Compare
AtomicFS
force-pushed
the
feat/multi-arch-docker
branch
from
October 1, 2024 13:43
a07edba
to
fcd0683
Compare
AtomicFS
force-pushed
the
feat/multi-arch-docker
branch
9 times, most recently
from
October 7, 2024 16:41
ac0695e
to
2c343be
Compare
AtomicFS
force-pushed
the
feat/multi-arch-docker
branch
6 times, most recently
from
October 9, 2024 15:17
634f911
to
aa7550d
Compare
AtomicFS
force-pushed
the
feat/multi-arch-docker
branch
5 times, most recently
from
October 27, 2024 08:12
99ffe7f
to
96ed75b
Compare
The linting issue is a known bug |
AtomicFS
force-pushed
the
feat/multi-arch-docker
branch
2 times, most recently
from
October 28, 2024 12:29
a2f69a2
to
568d95d
Compare
AtomicFS
changed the title
feat(docker): make containers multi-arch
feat(docker): make containers multi-arch (WIP)
Oct 30, 2024
Merged
Signed-off-by: AtomicFS <[email protected]>
BREAKING CHANGE: this commit changes how Docker containers are build Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
- since we no longer compile the toolchains, we can greatly simplify the dockerfile - we no longer need multi-stage build Signed-off-by: AtomicFS <[email protected]>
- this is necessary to support multi-architectural use Signed-off-by: AtomicFS <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
AtomicFS
force-pushed
the
feat/multi-arch-docker
branch
from
October 31, 2024 10:10
568d95d
to
01d5dec
Compare
AtomicFS
changed the title
feat(docker): make containers multi-arch (WIP)
feat(docker): make containers multi-arch
Oct 31, 2024
MDr164
reviewed
Oct 31, 2024
MDr164
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope I didn't miss anything but looks pretty solid to me
I could then add tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
amd64
amd64 / x86_64
arm64
arm64
docker
docker related
documentation
Improvements or additions to documentation
feature
New feature or request
github_actions
Pull requests that update GitHub Actions code
module/coreboot
module/edk2
module/linux
python
Pull requests that update Python code
testing
Testing related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all of our containers multi-architectural / multi-platform and fixes #341 .
At the moment we only support
x86_64
(akaamd64
) andarm64
(specificallyarm64 v8
).Todo:
There is a lot to comprehend, so here are some notes as to why:
u-root
andlinux
are OK to build the "normal way", however withedk2
andcoreboot
I get errors when trying to compile to tool-chains - I suspect the problem to be native emulation not supporting all of the instructions requiredx86
onx86
machine andarm64
onarm64
works fine, but buildingarm64
onx86
machine is broken (and vice versa)edk2
orcoreboot
multi-arch container on singlex86
machine as I canu-root
orlinux
x86
part onx86
machine andarm64
part onarm64
machine), publish them separately and then publish hand-crafted manifest connecting them together ... (seeThe hard way with docker manifest
in Multi-arch build and images, the simple waycoreboot
is fine, butedk2
is too much hassle (see feat(docker): compile toolchains separately #368)coreboot
and speed up the build by one order of magnitude (normally they take around 1 hour to compile)x86
architectures, since it is not really possible right now. We can only verify that the new changes did not break existing functionality.This is the final PR in the multi-arch saga, which contains breaking changes.