Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review #1

Open
3 tasks
ddongule opened this issue Apr 20, 2020 · 1 comment
Open
3 tasks

Review #1

ddongule opened this issue Apr 20, 2020 · 1 comment

Comments

@ddongule
Copy link
Member

ddongule commented Apr 20, 2020

๐Ÿ˜‰์ž˜ํ•œ ์ 

  • ํ”„๋กœ์ ํŠธ์™€ ๊ทธ ์•ˆ์˜ ์•ฑ๋“ค์„ ์ž˜ ๋งŒ๋“ค์–ด ๋ƒˆ์Šต๋‹ˆ๋‹ค.
  • ํ”„๋กœ์ ํŠธ์™€ ์•ฑ๋“ค์„ url์„ ํ†ตํ•ด ์ž˜ ์—ฐ๊ฒฐํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋‹ค์–‘ํ•œ html ํƒœ๊ทธ์™€ css๋ฅผ ์‚ฌ์šฉํ•ด ์œ ์ €๊ฐ€ ๋ณด๊ธฐ ์‰ฝ๊ฒŒ ํ”„๋กœํ•„ ํŽ˜์ด์ง€๋ฅผ ๋งŒ๋“ค์—ˆ์Šต๋‹ˆ๋‹ค.
  • ๋™์˜์ƒ๊ณผ ๋งํฌ๋ฅผ ํ™œ์šฉํ•ด ์•Œ์ฐฌ ๋‚ด์šฉ์˜ ์ž๊ธฐ์†Œ๊ฐœ๋ฅผ ์จ์ฃผ์—ˆ์Šต๋‹ˆ๋‹ค.
  • bootstrap์„ ํ™œ์šฉํ•ด ์˜ˆ์œ ์ž๊ธฐ์†Œ๊ฐœ ํŽ˜์ด์ง€๋ฅผ ๋งŒ๋“ค์–ด ์ฃผ์…จ์Šต๋‹ˆ๋‹ค.
  • static์„ ํ™œ์šฉํ•ด css๋ฅผ ์•Œ๋งž๊ฒŒ link ์‹œ์ผœ html ํŒŒ์ผ์„ ๊น”๋”ํ•˜๊ฒŒ ์ž˜ ๋งŒ๋“ค์–ด ์ฃผ์…จ์Šต๋‹ˆ๋‹ค.(๋‹ค์Œ์— ๋” ๊ฐ™์ด ๋ฐฐ์›Œ์š”!)

๐Ÿ˜Ž๊ฐœ์„  ์‚ฌํ•ญ(๊ฐ™์ด ๋ฐฐ์šธ ๋‚ด์šฉ์ด ํฌํ•จ๋˜์–ด ์žˆ์–ด์š”!)

  • myapp app์˜ urls.py์—์„œ views๋ฅผ import ํ•  ๋•Œ์— import myapp.views ๋ง๊ณ  from . import views๋ฅผ ์“ฐ์…”๋„ ์ข‹์Šต๋‹ˆ๋‹ค. ์–ด์ฐจํ”ผ myapp.views.์–ด์ฉŒ๊ณ  ์•ˆ์—์„œ myapp.๋Š” ๊ณ„์† ๋ฐ˜๋ณต๋  ๊ฒƒ์ด๋‹ˆ๊นŒ์š”! -> ์ž˜ ๋ชจ๋ฅด๊ฒ ์œผ๋ฉด ๋ฌผ์–ด๋ณด์„ธ์š”!
  • settings.py์˜ Installed apps์— ์•ฑ ์ถ”๊ฐ€ ํ›„ ์‰ผํ‘œ๋ฅผ ๋„ฃ์–ด์ฃผ์‹œ๋Š”๊ฒŒ ํ˜น์‹œ ๋ชจ๋ฅผ ์—๋Ÿฌ๋ฅผ ๋Œ€๋น„ํ•˜๊ธฐ ์ข‹์Šต๋‹ˆ๋‹ค.
    'portfolio', <- ์—ฌ๊ธฐ์š”!
  • commit message๋ฅผ ์กฐ๊ธˆ ๋” ๋ช…ํ™•ํ•˜๊ฒŒ ์“ฐ๋Š” ์—ฐ์Šต์„ ํ•ด๋ณด์…”๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

๐Ÿฅณ๋งŒ๋“œ๋Š๋ผ ์ˆ˜๊ณ ํ•˜์…จ์–ด์š”!

@milliwonkim
Copy link
Collaborator

๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค๐Ÿ˜„๐Ÿ˜„

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants