refactor: 내 피드 리스트 공개 상태 여부 정책 변경에 따른 API 수정 #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kdkdhoho
reviewed
Aug 30, 2024
src/main/java/com/listywave/user/application/service/UserService.java
Outdated
Show resolved
Hide resolved
src/test/java/com/listywave/acceptance/user/UserAcceptanceTestHelper.java
Outdated
Show resolved
Hide resolved
src/test/java/com/listywave/acceptance/user/UserAcceptanceTestHelper.java
Outdated
Show resolved
Hide resolved
src/test/java/com/listywave/acceptance/user/UserAcceptanceTestHelper.java
Outdated
Show resolved
Hide resolved
src/test/java/com/listywave/acceptance/user/UserAcceptanceTest.java
Outdated
Show resolved
Hide resolved
|
아 그리고 "리팩터링, 테스트"로 되어 있던 Label을 "기능, 리팩터링"으로 변경했습니다. |
kdkdhoho
reviewed
Sep 8, 2024
Comment on lines
+308
to
+313
| public void changeVisibility(Long loginUserId, Long listId) { | ||
| User user = userRepository.getById(loginUserId); | ||
| ListEntity list = listRepository.getById(listId); | ||
| list.validateOwner(user); | ||
| list.updateVisibility(); | ||
| } |
src/main/java/com/listywave/list/presentation/controller/ListController.java
Outdated
Show resolved
Hide resolved
src/test/java/com/listywave/acceptance/list/ListAcceptanceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/listywave/acceptance/list/ListAcceptanceTestHelper.java
Outdated
Show resolved
Hide resolved
| @@ -183,7 +183,7 @@ class ListEntityTest { | |||
| void 공개_여부를_수정할_수_있다() { | |||
| assertThat(list.isPublic()).isTrue(); | |||
|
|
|||
| list.updateVisibility(false); | |||
| list.updateVisibility(); | |||
kdkdhoho
approved these changes
Sep 8, 2024
| @@ -120,7 +120,7 @@ ResponseEntity<Void> deleteLists( | |||
| @RequestBody ListsDeleteRequest request | |||
| ) { | |||
| listService.deleteLists(userId, request.listId()); | |||
| return ResponseEntity.ok().build(); | |||
| return ResponseEntity.noContent().build(); | |||
pparkjs
force-pushed
the
refactor/289
branch
from
ea5dab7 to
e1d3b74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🛠️ 변경한 사항
ex) 1번 리스트가 공개인 경우
ASIS
그런데 이 방식은 프론트측에서 리스트 상세에서 받는 isPublic과 뭔가 매칭이 안되서 햇갈린다고 통일을 요청함
TOBE
해당 리스트가 공개일때 이를 비공개로 바꾸고자 할때 isPublic = false로 보냄( 내가 바꾸고 싶은 상태를 보내는 방식)
해당 부분에 테스트 코드가 존재하지 않아서 테스트 코드를 추가함!
Relation Issues