Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

how to add max_completion_tokens to CreateChatCompletionRequest? #291

Open
note89 opened this issue Nov 27, 2024 · 1 comment
Open

how to add max_completion_tokens to CreateChatCompletionRequest? #291

note89 opened this issue Nov 27, 2024 · 1 comment
Labels
spec sync Requires new changes published in upstream spec - openai-openapi

Comments

@note89
Copy link

note89 commented Nov 27, 2024

max_tokens are not valid for sending to 01preview and friends.
image

So, I need to be able to set max_completion_tokens instead. Can this be made possible?
In general, it would be great to add extra fields that are not defined in the library.
@note89 note89 changed the title how to add max_completion_tokens to CreateChatCompletionRequest? how to add max_completion_tokens to CreateChatCompletionRequest? Nov 27, 2024
@64bit
Copy link
Owner

64bit commented Nov 28, 2024

Thanks for the issue, seems like spec has been updated max_completion_tokens is new and max_tokens is deprecated https://platform.openai.com/docs/api-reference/chat/create#chat-create-max_completion_tokens

So CreateChatCompletionRequest type needs to be updated, PR is welcome!

@64bit 64bit added the spec sync Requires new changes published in upstream spec - openai-openapi label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec sync Requires new changes published in upstream spec - openai-openapi
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@64bit @note89