-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[suggestion] Let list methods take an Option argument #243
Comments
Thanks for suggestion, it can be improved, how about having two functions
I think |
I agree. I just followed #167 and tried to figure out a good compromise. BTW, a side note here. The query arguments are currently undocumented (vector store |
That's a good observation too about lack of documentation on Discussion in #167 was in context of missing the call for Files api group. It does seem like it needs to be addressed across the whole crate, that does sound like a breaking change where existing Its a small breaking-change and and an improvement so why not? Can be released in a version bump. In addition, breaking change is ok too because |
Oh, I know this tone... :) Unfortunately, as you can see, I barely find time on side-projects now. Had to even quit Raku development. Otherwise it'd be my pleasure! |
No obligations, thank you for your contributions, the issue is going to be here if you wanna give it a shot. |
Maybe this is my lack of experience, but when I'm requesting just a full list of objects like files I have to write something like:
Wouldn't it be better to let it be just
files.list(None).await?
?The text was updated successfully, but these errors were encountered: