Display tx with 1 owner in queue if direct execution failed.

[francovenica]

Env

https://safe-team.dev.gnosisdev.com/app/

Steps

Create a safe with 1 owner
Create a tx and give it low gas on purpose (to force the tx's failure)
Sign and execute the tx
The system will tell you that the tx failed

Result

Nothing is shown in the Queue or History tab

Expected

The tx to be shown as a tx on "awaiting for execution" tx on the queue tab

[rmeissner]

Just to be specific: you mean when the tx reverts, right? If the safe tx fails (so the ethereum tx is still a success) then you would see it in the history.

[tschubotz]

What do we even expect in such a case? Should there be a tx in the queue with 0/1 signatures?

[tschubotz]

I think expected behavior there should be: Show 0/1 or 1/1 signatures and the user can just re-execute.

[francovenica]

With the introduction of the deep link view this particular issue is now different:
In a safe v1.3.0 and 1/1 policy, create a tx "Contract Interaciton" using the mastercopy contract, setting the method changeTrheshold and putting a really hign number as value (basically forcing the tx to fail)

Now the tx is created and is shown in its deep link view.
While pending the tx just shows 1/1 confirmation and pending status
As soon as the tx fails, the status is "needs execution", but you cannot Confirm or Reject this tx because technically it doesn't exist
The tx is not queued or shown in the history tab at all after this (again, is like if the tx never existed)
No notifications about the tx failing were shown

We should discuss what to do after the tx fails, so it doesn't sit there in the deep link view until the user decides to exit that page.

Snapshots:
While processing

After it fails