Skip to content

Commit

Permalink
Merged in DSC-1387-export-menu-in-person-entity-main-cris (pull request
Browse files Browse the repository at this point in the history
DSpace#1315)

DSC-1387 export menu in person entity main cris

Approved-by: Davide Negretti
  • Loading branch information
vNovski authored and Davide Negretti committed Feb 6, 2024
2 parents 4c2d08c + 02d4e04 commit 48b8f4b
Show file tree
Hide file tree
Showing 9 changed files with 25 additions and 7 deletions.
5 changes: 3 additions & 2 deletions src/app/core/data/processes/process-data.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,11 @@ export class ProcessDataService extends IdentifiableDataService<Process> impleme
/**
* Get a process' output files
* @param processId The ID of the process
* @param useCacheVersionIfAvailable If value needs to be red from cache or not
*/
getFiles(processId: string): Observable<RemoteData<PaginatedList<Bitstream>>> {
getFiles(processId: string, useCacheVersionIfAvailable = true): Observable<RemoteData<PaginatedList<Bitstream>>> {
const href$ = this.getFilesEndpoint(processId);
return this.bitstreamDataService.findListByHref(href$);
return this.bitstreamDataService.findListByHref(href$, {}, useCacheVersionIfAvailable);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/app/process-page/detail/process-detail.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export class ProcessDetailComponent implements OnInit, OnDestroy {

this.filesRD$ = this.processRD$.pipe(
getFirstSucceededRemoteDataPayload(),
switchMap((process: Process) => this.processService.getFiles(process.processId))
switchMap((process: Process) => this.processService.getFiles(process.processId, false)),
);
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<div *ngIf="logo" class="dso-logo mb-3">
<img [src]="logo._links.content.href" class="img-fluid" [attr.alt]="alternateText ? alternateText : null" (error)="errorHandler($event)"/>
<img [src]="logo._links.content.href" class="w-100 img-fluid" [attr.alt]="alternateText ? alternateText : null" (error)="errorHandler($event)"/>
</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
img {
max-width: var(--ds-comcol-logo-max-width);
max-height: var(--ds-comcol-logo-max-height);
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
[formControl]="input" ngbAutofocus (keyup.enter)="selectSingleResult()">
</div>
<div class="dropdown-divider"></div>
<div class="scrollable-menu list-group">
<div id="scrollable-menu-dso-selector-{{randomSeed}}" class="scrollable-menu list-group">
<div
infiniteScroll
[infiniteScrollDistance]="1"
[infiniteScrollThrottle]="0"
[infiniteScrollContainer]="'.scrollable-menu'"
[infiniteScrollContainer]="'#scrollable-menu-dso-selector-' + randomSeed"
[fromRoot]="true"
(scrolled)="onScrollDown()">
<ng-container *ngIf="listEntries$ | async">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@ export class DSOSelectorComponent implements OnInit, OnDestroy {
*/
public subs: Subscription[] = [];

/**
* Random seed of 4 characters to avoid duplicate ids
*/
randomSeed: string = Math.random().toString(36).substring(2, 6);

constructor(
protected searchService: SearchService,
protected notifcationsService: NotificationsService,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
:host {
display: none;
}

.dropdown-menu {
z-index: 1020;
}
2 changes: 1 addition & 1 deletion src/app/shared/search/search.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
</ng-template>

<ng-template #searchForm>
<div class="d-flex flex-wrap flex-xl-nowrap search-form-flex-wrapper">
<div class="d-flex flex-wrap flex-xl-nowrap search-form-flex-wrapper" [class.justify-content-end]="!searchEnabled">
<div *ngIf="!(isXsOrSm$ | async) && showFilterToggle && showSidebar">
<button class="btn btn-outline-secondary"
ngbTooltip="{{'search.sidebar.show.hide.filters.tooltip' | translate}}"
Expand Down
4 changes: 4 additions & 0 deletions src/styles/_custom_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -140,4 +140,8 @@
--ds-dso-edit-security-width: 136px;
--ds-dso-edit-actions-width: 173px;
--ds-dso-edit-virtual-tooltip-min-width: 300px;


--ds-comcol-logo-max-width: 500px;
--ds-comcol-logo-max-height: 500px;
}

0 comments on commit 48b8f4b

Please sign in to comment.