Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4D-OBC change detection: Window_with parameter causes runtime error #266

Open
vivienzahs opened this issue Jul 17, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@vivienzahs
Copy link
Contributor

For the 4D-OBC change point detection, the window_width parameter is not allowed to be larger than the number of epochs in the dataset. This causes a RunTimeError ("empty score") to be raised during the seed point selection in the region growing any time when having generated the SpatiotemporalAnalysis object based on more than 2 epochs (1 reference epoch + several further epochs).

Maybe the limitation of this parameter to not be larger than the number of epochs in the dataset could be removed and a meaningful error message might be provided to the user to better identify where the issues comes from.

Happy to provide more information if required.

@dokempf dokempf added the bug Something isn't working label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants