From 01ab68209a0c4550dbe2b5e419258a08eeee4ff7 Mon Sep 17 00:00:00 2001
From: Evgeny Safronov <division494@gmail.com>
Date: Tue, 27 Jun 2017 20:40:14 +0300
Subject: [PATCH] feat: add missing overflow policies compositors

---
 include/blackhole/sink/asynchronous.hpp | 11 ++++++++-
 src/sink/asynchronous.cpp               | 21 +++++++++++++++-
 src/sink/asynchronous.hpp               |  2 +-
 tests/src/unit/sink/asynchronous.cpp    | 32 +++++++++++++++++++++++++
 4 files changed, 63 insertions(+), 3 deletions(-)

diff --git a/include/blackhole/sink/asynchronous.hpp b/include/blackhole/sink/asynchronous.hpp
index e8c0c2e8..cbffc95e 100644
--- a/include/blackhole/sink/asynchronous.hpp
+++ b/include/blackhole/sink/asynchronous.hpp
@@ -39,7 +39,8 @@ class builder<sink::asynchronous_t> {
 public:
     /// Constructs a sink builder from some other sink.
     ///
-    /// The ownership of the specified sink is transferred to the builder.
+    /// The ownership of the specified sink is transferred to the builder. The default overflow
+    /// policy will block the calling thread while the internal message queue is full.
     ///
     /// \param wrapped The target sink (usually the blocking one) that is need to make asynchronous.
     explicit builder(std::unique_ptr<sink_t> wrapped);
@@ -48,6 +49,14 @@ class builder<sink::asynchronous_t> {
     auto factor(std::size_t value) & -> builder&;
     auto factor(std::size_t value) && -> builder&&;
 
+    /// Sets the drop overflow policy.
+    auto drop() & -> builder&;
+    auto drop() && -> builder&&;
+
+    /// Sets the wait overflow policy.
+    auto wait() & -> builder&;
+    auto wait() && -> builder&&;
+
     /// Consumes this builder yielding a newly created asynchronous sink with the options
     /// configured.
     auto build() && -> std::unique_ptr<sink_t>;
diff --git a/src/sink/asynchronous.cpp b/src/sink/asynchronous.cpp
index b5ddcb41..d60d0602 100644
--- a/src/sink/asynchronous.cpp
+++ b/src/sink/asynchronous.cpp
@@ -16,11 +16,12 @@ inline namespace v1 {
 class builder<sink::asynchronous_t>::inner_t {
 public:
     std::unique_ptr<sink_t> wrapped;
+    std::unique_ptr<sink::overflow_policy_t> overflow_policy;
     std::size_t factor;
 };
 
 builder<sink::asynchronous_t>::builder(std::unique_ptr<sink_t> wrapped) :
-    d(new inner_t{std::move(wrapped), 10})
+    d(new inner_t{std::move(wrapped), sink::overflow_policy_factory_t().create("wait"), 10})
 {}
 
 auto builder<sink::asynchronous_t>::factor(std::size_t value) & -> builder& {
@@ -32,6 +33,24 @@ auto builder<sink::asynchronous_t>::factor(std::size_t value) && -> builder&& {
     return std::move(factor(value));
 }
 
+auto builder<sink::asynchronous_t>::wait() & -> builder& {
+    d->overflow_policy = sink::overflow_policy_factory_t().create("wait");
+    return *this;
+}
+
+auto builder<sink::asynchronous_t>::drop() && -> builder&& {
+    return std::move(wait());
+}
+
+auto builder<sink::asynchronous_t>::drop() & -> builder& {
+    d->overflow_policy = sink::overflow_policy_factory_t().create("drop");
+    return *this;
+}
+
+auto builder<sink::asynchronous_t>::wait() && -> builder&& {
+    return std::move(wait());
+}
+
 auto builder<sink::asynchronous_t>::build() && -> std::unique_ptr<sink_t> {
     return blackhole::make_unique<sink::asynchronous_t>(std::move(d->wrapped), d->factor);
 }
diff --git a/src/sink/asynchronous.hpp b/src/sink/asynchronous.hpp
index 46c41dda..951a00ef 100644
--- a/src/sink/asynchronous.hpp
+++ b/src/sink/asynchronous.hpp
@@ -20,7 +20,7 @@ class overflow_policy_t {
     };
 
 public:
-    virtual ~overflow_policy_t() {}
+    virtual ~overflow_policy_t() = default;
 
     /// Handles record queue overflow.
     ///
diff --git a/tests/src/unit/sink/asynchronous.cpp b/tests/src/unit/sink/asynchronous.cpp
index a5dc8afc..fc25c603 100644
--- a/tests/src/unit/sink/asynchronous.cpp
+++ b/tests/src/unit/sink/asynchronous.cpp
@@ -85,6 +85,38 @@ TEST(asynchronous_t, BuilderSetFactorFlow) {
     EXPECT_EQ(32, dynamic_cast<asynchronous_t&>(*sink).capacity());
 }
 
+TEST(asynchronous_t, BuilderSetDropOverflowPolicy) {
+    std::unique_ptr<mock::sink_t> wrapped(new mock::sink_t);
+
+    builder<asynchronous_t> builder(std::move(wrapped));
+    builder.drop();
+    std::move(builder).build();
+}
+
+TEST(asynchronous_t, BuilderSetDropOverflowPolicyFlow) {
+    std::unique_ptr<mock::sink_t> wrapped(new mock::sink_t);
+
+    builder<asynchronous_t>(std::move(wrapped))
+        .drop()
+        .build();
+}
+
+TEST(asynchronous_t, BuilderSetWaitOverflowPolicy) {
+    std::unique_ptr<mock::sink_t> wrapped(new mock::sink_t);
+
+    builder<asynchronous_t> builder(std::move(wrapped));
+    builder.wait();
+    std::move(builder).build();
+}
+
+TEST(asynchronous_t, BuilderSetWaitOverflowPolicyFlow) {
+    std::unique_ptr<mock::sink_t> wrapped(new mock::sink_t);
+
+    builder<asynchronous_t>(std::move(wrapped))
+        .wait()
+        .build();
+}
+
 }  // namespace
 }  // namespace sink
 }  // namespace v1