Incorrect syntax near 'returning'.

[jhchill666]

I just can't figure out how returning should work.

Builder config:
{ dialect: 'mssql', separatedValues: false }

Query:

const query = {
        table: 'Messages',
        type: 'insert',
        returning: ['ID'],
        values: {
          Name: 'Blah',
          Text: 'Some text'
        }
      }

Yeilds:
insert into "Messages" ("Name", "Text") values ('Blah', 'Some text') returning "ID";

Error:
RequestError: Incorrect syntax near 'returning'.

Obviously this will fail, as is not valid MSSQL syntax.

Am just trying to output the inserted row's primary key. It doesn't seem like valid

[jhchill666]

Ok, upon further investigation, seems that mssql dialect just uses the base dialect.

Seems there's a PR associated with this, but is 2 years old.

Is this library still maintained? Will the PR ever be merged?

[okv]

Hello there.
Library is maintained but mostly for base dialect and postgresql.
It turned out that it's not just that simple to support a bunch of dialects (especially when you aren't using most them at all).
I don't think that ms sql dialect will be merged, sorry for that.