forked from 2DegreesInvesting/ds-incubator
-
Notifications
You must be signed in to change notification settings - Fork 0
/
2019-11-12_pr-interdependent.Rmd
75 lines (40 loc) · 1.76 KB
/
2019-11-12_pr-interdependent.Rmd
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
---
output: github_document
---
# Interdependent pull requests
## Situation
After the contributor submitted a first pull request (`pr1`), and
before the maintainer merges it into the source repository, the contributor
starts a second pull request (`pr2`) that depends on `pr1`.
The maintainer edits `pr1` and accepts it (squash-merges it into the upstream/master). But `pr2` now is a mess and the contributor must fix it before it can be merged.
## `pr_init("pr1")`
<img src="https://i.imgur.com/vViZK38.png" width = 750 />
## New `f()`
<img src="https://i.imgur.com/vdWYsNB.png" width = 750 />
## `pr_push()`
<img src="https://i.imgur.com/49c8ayi.png" width = 750 />
<img src="https://i.imgur.com/mwfQGjD.png" width = 750 />
## `pr_init("pr2")`
<img src="https://i.imgur.com/0qBnkt5.png" width = 750 />
## New `g()`
<img src="https://i.imgur.com/4V5k3fz.png" width = 750 />
## `pr_push()`
<img src="https://i.imgur.com/MP2yvyX.png" width = 750 />
<img src="https://i.imgur.com/y2Oh0bk.png" width = 750 />
## `pr_fetch()` (Maintainer)
<img src="https://i.imgur.com/oqXfvQC.png" width = 750 />
## Edit `pr1` (Maintainer)
<img src="https://i.imgur.com/gkiMWV4.png" width = 750 />
## `pr_push()` (Maintainer)
<img src="https://i.imgur.com/6iYglIS.png" width = 750 />
<img src="https://i.imgur.com/7WeMLDE.png" width = 700 />
## `pr_sync()`
<img src="https://i.imgur.com/Q3qlilr.png" width = 750 />
## Fix `pr2` then `pr_push()`
<img src="https://i.imgur.com/Z49R2th.png" width = 750 />
<img src="https://i.imgur.com/MtpentI.png" width = 750 />
## Squash-merge `pr2` (Maintainer)
<img src="https://i.imgur.com/NGoM90n.png" width = 750 />
## `pr_finish()`
<img src="https://i.imgur.com/BP17N3S.png" width = 750 />
<img src="https://i.imgur.com/TFsvsns.png" width = 750 />