Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify two code pieces in record manipulation #1009

Merged
merged 2 commits into from
Oct 10, 2023
Merged

simplify two code pieces in record manipulation #1009

merged 2 commits into from
Oct 10, 2023

Conversation

ImpleLee
Copy link
Contributor

@ImpleLee ImpleLee commented Oct 9, 2023

No description provided.

@MrZ626
Copy link
Collaborator

MrZ626 commented Oct 9, 2023

有不在函数内定义新函数的实现么

@ImpleLee
Copy link
Contributor Author

ImpleLee commented Oct 9, 2023

没有吧。为啥这样不行？

@ImpleLee
Copy link
Contributor Author

ImpleLee commented Oct 9, 2023

encode能拆出来，decode不是很好拆。

@MrZ626
Copy link
Collaborator

MrZ626 commented Oct 9, 2023

因为这样每执行一次都会创建一个新的函数对象，跑完了再回收掉，比较不适，我能不这么写就不这么写的

@ImpleLee
Copy link
Contributor Author

ImpleLee commented Oct 9, 2023

不是不行吧，那我拆出来吧。

@MrZ626 MrZ626 merged commit 69a288d into main Oct 10, 2023
11 checks passed
@MrZ626 MrZ626 deleted the code-simplification branch October 10, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImpleLee @MrZ626