Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes for Single Log Out #30

Open
f3cp opened this issue Aug 9, 2022 · 2 comments
Open

Routes for Single Log Out #30

f3cp opened this issue Aug 9, 2022 · 2 comments

Comments

@f3cp
Copy link

f3cp commented Aug 9, 2022

Firstly, according to the documentation, "By logging out of the global SSO Session. In this case the IdP will notify you on /saml2/{uuid}/slo endpoint (already provided)." however an /slo endpoint does not appear to be included in the routes specified in the packages routes file.

I notice that an /sls endpoint is also mentioned (which does exist). Are these 2 seperate endpoints or is this just a typo.

Secondly, assuming the /sls endpoint is correct, the behaviour of the /sls endpoint does not appear to match the actions performed upon logout by my idp (OKTA), which is making a POST request to that endpoint (as outlined here). The /sls endpont only accepts GET requests and additionally does not appear to pass on any data related to the logout when it fires the SignedOut event, which seems to contain no methods. This data would be useful to ensuring that I am logging out the correct user from an IDP initiated logout.

It looks like i'm going to need to implement my own endpoint to handle SLO, but just wanted to check if there was something I was missing, since this is described as being implemented according to the docs.

Thanks in advance for any light you can shed on this.

@f3cp
Copy link
Author

f3cp commented Aug 9, 2022

I dug a little deeper and it looks like this is the issue that I have come up against in relation to the POST request from OKTA. Basically the OneLogin Toolkit does not support it, and Okta won't change their behaviour.

So I guess the only outstanding issue in relation to this package is the possible typo in the docs for /slo endpont, and maybe also, whether additional data could be made available in the SignedOut event.

@dmyers
Copy link
Contributor

dmyers commented Sep 16, 2022

Take a look at PR #38 where I ran into this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants