Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] users 공통 코드 작성 #7

Merged
merged 3 commits into from
Aug 23, 2024
Merged

[feat] users 공통 코드 작성 #7

merged 3 commits into from
Aug 23, 2024

Conversation

jw427
Copy link
Contributor

@jw427 jw427 commented Aug 22, 2024

Issue

PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트

반영 브랜치

feat/user -> dev

변경 사항

users 공통 코드 작성

@jw427 jw427 added the feat label Aug 22, 2024
@jw427 jw427 linked an issue Aug 22, 2024 that may be closed by this pull request
회원 기능 공통 코드 작성 #6
Open
4 tasks
pie2457
pie2457 reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@pie2457 pie2457 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 반영하시면 Approve 하겠습니다! 수고하셨습니다 😊

src/main/java/wanted/media/user/repository/UserRepository.java Outdated

import java.util.UUID;

@Repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 어노테이션 제거 해주셔도 됩니다~

src/main/java/wanted/media/user/domain/Code.java Outdated
@NoArgsConstructor
@AllArgsConstructor
@Getter
@Builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Builder 는 사용하실 때 달아두면 좋을 것 같습니다 ~

src/main/java/wanted/media/user/domain/Code.java
@Getter
@Builder
@Entity
@Table(name = "codes")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DB 테이블을 추가하셨다면 노션에 ERD도 변경 해주시면 좋을 것 같아요 ~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

노션에 추가해놓겠습니다!

src/main/java/wanted/media/user/domain/Token.java Outdated
@Column(name = "refresh_token", nullable = false)
private String refreshToken;

@ManyToOne
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 즉시로딩과 지연로딩에 대해 찾아보시고 적용해주시면 좋을 것 같습니다!

src/main/java/wanted/media/user/domain/Code.java Outdated

@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
@Column(name = "code_id", nullable = false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Column의 name 조건은 왜 사용하는지 알고 계신가요??? 확인해보시고 사용하시면 좋을 것 같습니다 ! 다른 클래스들도 전부 ㅎㅎㅎ

pie2457
pie2457 approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@pie2457 pie2457 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 ~!😊

@K-0joo
Copy link
Contributor

K-0joo commented Aug 23, 2024

수고하셨습니다 👏👏

@jw427 jw427 merged commit 20ad8a6 into dev Aug 23, 2024
@jw427 jw427 deleted the feat/user branch August 23, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongeungyeong jeongeungyeong jeongeungyeong left review comments

@ssunnykku ssunnykku ssunnykku approved these changes

@pie2457 pie2457 pie2457 approved these changes

@K-0joo K-0joo K-0joo approved these changes

@rhaehf rhaehf rhaehf approved these changes

Assignees

@jw427 jw427

@jeongeungyeong jeongeungyeong

Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

회원 기능 공통 코드 작성
6 participants
@jw427 @K-0joo @rhaehf @pie2457 @ssunnykku @jeongeungyeong