Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: split config file #17

Open
acyanic opened this issue Aug 13, 2018 · 3 comments
Open

Feature request: split config file #17

acyanic opened this issue Aug 13, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@acyanic
Copy link

acyanic commented Aug 13, 2018

could this have the config file split into separate parts, eg

  1. config.json for the timing parameters
  2. rooturl.json for the root urls
  3. blacklisted.json for blacklisted urls
  4. useragent.json for the user agents
    a little easier to manage special cases eg testing scenarios or personal preferences
@Arduous
Copy link
Contributor

Arduous commented Sep 1, 2018

Have a look at the branch https://github.com/Arduous/noisy/commits/featMultipleConfFiles
Provided that you have properly split the config json files, it should be run with
python noisy.py --config config.json --config blacklisted.json --config rooturl.json --config useragent.json
If it works for you, I'll open a pull request

@1tayH 1tayH added the enhancement New feature or request label Sep 7, 2018
@acyanic
Copy link
Author

acyanic commented Sep 11, 2018 via email

@Arduous
Copy link
Contributor

Arduous commented Sep 11, 2018

It would be definitely doable.

The solution I proposed is altering very slightly the existing code base, using standard library functionalities.

I think (I would be happy to be proven false) that having config files definition within the main config file would require the addition of some json custom parsing logic. Let's see what @1tayH thinks if this functionality worth the complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants