-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: split config file #17
Comments
Have a look at the branch https://github.com/Arduous/noisy/commits/featMultipleConfFiles |
Sorry am on holiday until oct. This helps but makes the command line
clunky. Although ok from a script.
Can json files be hierarchical ? so a master json has links to sub json
files?
Andy
…On Sun, 2 Sep 2018, 02:00 Samuel Progin, ***@***.***> wrote:
Have a look at the branch
https://github.com/Arduous/noisy/commits/featMultipleConfFiles
Provided that you have properly split the config json files, it should be
run with
python noisy.py --config config.json --config blacklisted.json --config
rooturl.json --config useragent.json
If it works for you, I'll open a pull request
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#17 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AoJJAJvDAdlBPAoxILTSUMLfn9L0pMbtks5uWxGYgaJpZM4V6y3G>
.
|
It would be definitely doable. The solution I proposed is altering very slightly the existing code base, using standard library functionalities. I think (I would be happy to be proven false) that having config files definition within the main config file would require the addition of some json custom parsing logic. Let's see what @1tayH thinks if this functionality worth the complexity. |
could this have the config file split into separate parts, eg
a little easier to manage special cases eg testing scenarios or personal preferences
The text was updated successfully, but these errors were encountered: