Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Indentation left does not work any more in latest version #171

Open
android-outliner opened this issue Mar 25, 2023 · 0 comments
Open

Comments

@android-outliner
Copy link
Contributor

android-outliner commented Mar 25, 2023

If you press the indentation right button, everything is ok.
Indentation left does intent to the right instead of indent to the left.

In the latest RT-Editor Demo App the issue can be simply reproduced.

The reason seems to be this code in HorizontalRTToolbar.java (line 646):

        else if (id == R.id.toolbar_inc_indent) {
            mListener.onEffectSelected(Effects.INDENTATION, Helper.getLeadingMarging());
        }

        else if (id == R.id.toolbar_dec_indent) {
            mListener.onEffectSelected(Effects.INDENTATION, Helper.getLeadingMarging());     //**** minus missing ****
        }

For R.id.toolbar_dec_indent a minus is missing: -Helper.getLeadingMarging()

It worked in an older version. The error seems to be introduced when migrating to AndroidX.
This is the problematic commit:
6982075

Unfortunately I can't stick to any older version because the Google Play Store complains the old version of org.greenrobot:eventbus:3.1.1 inside the RTEditor library when uploading my App.

@android-outliner android-outliner changed the title indentation left does not work any more in latest version [BUG] Indentation left does not work any more in latest version Mar 25, 2023
android-outliner added a commit to android-outliner/Android-RTEditor that referenced this issue Apr 15, 2023
1gravity added a commit that referenced this issue May 29, 2023
[BUG] Indentation left does not work any more in latest version #171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant