Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diacritics disappear in CodeMirror on GitHub #181

Open
1ec5 opened this issue Jul 4, 2017 · 4 comments
Open

Diacritics disappear in CodeMirror on GitHub #181

1ec5 opened this issue Jul 4, 2017 · 4 comments

Comments

@1ec5
Copy link
Owner

1ec5 commented Jul 4, 2017

In CodeMirror text areas, any diacritics added by AVIM disappear as soon as the user adds another diacritic.

Among the places CodeMirror is used are GitHub and soon Wikimedia’s MediaWiki installations. Supporting Vietnamese text input while editing Wikipedia is a critical priority for AVIM.

(Per #135, AVIM used to work in CodeMirror by default, but something changed with that library in the last year or so, breaking AVIM.)

@1ec5 1ec5 changed the title Diacritics disappear in CodeMirror Diacritics disappear in CodeMirror on GitHub Jul 4, 2017
@1ec5
Copy link
Owner Author

1ec5 commented Jul 4, 2017

Actually, most of the demos at the CodeMirror site work fine. I’ve observed this issue at GitHub; it might be due to one of the addons GitHub installs. This is still important to investigate, because it’s likely that MediaWiki will be using many of the same addons.

@1ec5
Copy link
Owner Author

1ec5 commented Jul 4, 2017

GitHub installs the following addons:

[
  'codemirror/addon/comment/comment',
  'codemirror/mode/meta',
  'codemirror/addon/mode/simple',
  'codemirror/addon/mode/overlay',
  'codemirror/addon/mode/multiplex',
  'codemirror/addon/dialog/dialog',
  'codemirror/addon/search/search',
  'codemirror/addon/search/searchcursor',
  'codemirror/addon/search/jump-to-line',
  'codemirror-contrib/lib/mode/meta'
]

@1ec5
Copy link
Owner Author

1ec5 commented Jul 7, 2017

Confirmed that diacritics are preserved on the version of CodeMirror being deployed at Test Wikipedia. However, the dead key for removing diacritics (e.g., - in VIQR) doesn’t work after placing the insertion point at the end of a line.

@1ec5
Copy link
Owner Author

1ec5 commented May 8, 2018

Confirmed that diacritics are preserved on the version of CodeMirror being deployed at Test Wikipedia.

AVIM works with the Code_Editor_ extension and with VisualEditor – including when displaying syntax-highlighted code in VisualEditor. However, AVIM doesn’t work with CodeMirror when embedded inside the older wikitext editor. AVIM suffers from the same issue that plagues jQuery.ime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant