Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diacritics stripped when posting Facebook comment #171

Closed
1ec5 opened this issue Jun 11, 2016 · 4 comments
Closed

Diacritics stripped when posting Facebook comment #171

1ec5 opened this issue Jun 11, 2016 · 4 comments

Comments

@1ec5
Copy link
Owner

1ec5 commented Jun 11, 2016

As reported on AMO, #105 recently regressed, probably due to a change Facebook made. Submitting any text field on a profile page or chat box strips the text of any diacritics entered since the last plain character.

This issue does not reproduce with system input methods in Firefox on OS X; however, Firefox gets very confused about where the keyboard focus is, suggesting that Facebook is doing something unusual with the textbox.

Possibly related to kimkha/avim-chrome#18.

@1ec5
Copy link
Owner Author

1ec5 commented Jun 11, 2016

Facebook also strips the diacritics as soon as you focus some other element on the page then refocus the textbox, or as soon as you switch tabs or windows and back.

@1ec5
Copy link
Owner Author

1ec5 commented Jun 11, 2016

At this point, the most likely culprit is that the React component that manages the contenteditable box (react-composer) is overwriting the box’s contents with the value of a property in the component’s model.

@1ec5
Copy link
Owner Author

1ec5 commented Jun 12, 2016

The component tree looks something like this:

<ComposerStatusAttachmentMentionsInputWithTagExpansionContainer>
<ComposerStatusAttachmentMentionsInputContainer>
<ReactComposerStatusAttachmentMentionsInput>
<MentionsInput>
div
<AbstractMentionsTextEditor>
div
<n>

@1ec5
Copy link
Owner Author

1ec5 commented Jun 12, 2016

AVIM once again works in Facebook and Messenger as of v5.7.0b2, which is in the beta channel. Barring complications, I’ll publish to the release channel in a few days.


AVIM lại tương thích với Facebook và Messenger trong phiên bản 5.7.0b2, phiên bản đó trong kênh beta. Nếu không có sao, tôi sẽ xuất bản cho kênh chính trong vòng vài ngày.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant