Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing funding pool with erc20 transfers #445

Open
Corantin opened this issue Sep 25, 2024 · 2 comments
Open

Consider allowing funding pool with erc20 transfers #445

Corantin opened this issue Sep 25, 2024 · 2 comments
Assignees

Comments

@Corantin
Copy link
Contributor

Corantin commented Sep 25, 2024

Reasons:

  • way more flexible (would support streaming or direct erc20 transfer)
  • allo.fundPool not usefull: only reason is allo protocol fee but allo is not collecting fee on any supported chains
  • more reliable if someone still decide to make a erc20 transfer
  • can be hooked with external protocols more easily (like gardens v1)

Change impacts:

Contract:

  • change getPoolAmount to return balance of the token
  • replace totalAmount field to getter function call
  • remove PoolAmountIncreased

Subgraph:

  • Remove any reference to poolAmount in mapping and schema

Frontend

  • only place that is using the subgraph field totalAmount
    Image
@Corantin Corantin self-assigned this Sep 25, 2024
@Corantin Corantin converted this from a draft issue Sep 25, 2024
@Corantin Corantin added this to the Beta milestone Sep 25, 2024
@Corantin
Copy link
Contributor Author

Mea culpa: The subgraph poolAmount is updated when a proposal is executed through the Distributed event
Image

@Corantin
Copy link
Contributor Author

Freezing this for now cause after double check, the flow is working.
Other reason is we would not be able to use Allo as the centralized TVL record contract

@Corantin Corantin removed this from the Beta milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

No branches or pull requests

1 participant