Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle settlement of proposals after settlement period elapsed #892

Open
0xGabi opened this issue Oct 21, 2022 · 0 comments
Open

Handle settlement of proposals after settlement period elapsed #892

0xGabi opened this issue Oct 21, 2022 · 0 comments
Labels
🙋‍♀️ good first issue Good for newcomers

Comments

@0xGabi
Copy link
Member

0xGabi commented Oct 21, 2022 •
edited
Loading

As a user I want to settle a proposal after the settlement period.

We need to include the logic to call this method on the Agreement app of the Garden: https://github.com/1Hive/agreement-app/blob/master/contracts/Agreement.sol#L416

Note the actionId is already on the proposal object.
@0xGabi 0xGabi added the 🙋‍♀️ good first issue Good for newcomers label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙋‍♀️ good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0xGabi