Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garden-ui app should not ask for switch network if not the active tab #866

Open
Corantin opened this issue Jul 24, 2022 · 1 comment
Open

Comments

@Corantin
Copy link
Contributor

Problem

Switch wallet network and Gardens-UI opened in another tab resulting in metamask asking us to switch network back to the one before.

Repro

  1. We change network in another chain (from gnosis to Rinkeby)
    image

  2. Gardens ask to switch network
    image

Suggestion

Only ask to chain network when Gardens-UI app is the active tab

Example in Quests : https://github.com/1Hive/quests/blob/main/packages/react-app/src/contexts/wallet.context.tsx#:~:text=%20!document.hidden%20%26%26

@kamikazebr
Copy link
Member

Yeah the #825 have the idea fix that, but its need some review to be approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants