Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token metadata: Use deafult-token-list library #459

Open
fabriziovigevani opened this issue May 24, 2021 · 2 comments
Open

Token metadata: Use deafult-token-list library #459

fabriziovigevani opened this issue May 24, 2021 · 2 comments
Labels

Comments

@fabriziovigevani
Copy link
Member

It would be nice to get the token metadata (logo, etc) from the default-token-list library instead of requiring it in the dao-list library.

@fabriziovigevani fabriziovigevani added the 🙋‍♂️ request Feature request label May 24, 2021
@onbjerg onbjerg added the 🙋‍♀️ good first issue Good for newcomers label Jun 12, 2021
@Harthor Harthor assigned Harthor and unassigned Harthor Jun 17, 2021
@Harthor
Copy link
Member

Harthor commented Jun 19, 2021

Gave this one a try but had errors when trying to build it

First added default-token-list with yarn add 1hive/default-token-list
Screen Shot 2021-06-19 at 09.08.07.png

Then installed with yarn

Then tried running yarn build in the root folderScreen Shot 2021-06-18 at 21.58.50.png
with no success, although the document got created but with nothing inside Screen Shot 2021-06-18 at 21.59.49.png

Also got errors running yarn build in the node_modules/@1hive/default-token-list folder

Not really sure how to continue to make the build

@metaverde
Copy link

Is this still an issue?
Or should we be looking at another Gardens repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants