Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize current week in list of weeks that are due #1770

Closed
kingcomma opened this issue Jun 21, 2024 · 6 comments
Closed

Emphasize current week in list of weeks that are due #1770

kingcomma opened this issue Jun 21, 2024 · 6 comments
Assignees

Comments

@kingcomma
Copy link
Member

kingcomma commented Jun 21, 2024

As someone who tocks their time, it can be difficult to find the current week in the list of weeks that are due on the Tock homepage. The visual differences between the links are usually subtle (June ..., June ..., June ...) and the current week is at the bottom of the list when my instinct is for it to be at the top. This has led to me filling out the wrong week and then having to request a tock admin's time to perform a correction.

At the risk of designing as a non-designer, some way to visually indicate the current week (if it has not yet been completed) in the list would be helpful. For example, the list currently looks like:

Screenshot 2024-06-21 at 4 05 59 PM

Compare to this re-ordered list with the current week bolded:

Screenshot 2024-06-21 at 4 07 41 PM
@juliaklindpaintner
Copy link
Member

Was here to submit this same issue, so adding a heavy plus 1 instead. This same thing has happened to 2 of my direct reports in the last 2 weeks!

@bpdesigns
Copy link
Member

@adunkman I'm prioritizing this a a quick design fix that will help the 18F team

@melchoyce
Copy link
Member

melchoyce commented Sep 3, 2024

Quick suggestion. What if we did two things:

  1. Call out the current week (and past due) separately from future weeks
  2. Reverse how the weeks are displayed so the sooner ones at the top and later ones at the bottom

image

If this sounds good, we'll need an engineer who can implement it.

@nateborr nateborr assigned nateborr and unassigned nateborr Sep 26, 2024
@peterrowland peterrowland self-assigned this Oct 1, 2024
@caleywoods
Copy link
Contributor

Quick suggestion. What if we did two things:

  1. Call out the current week (and past due) separately from future weeks
  2. Reverse how the weeks are displayed so the sooner ones at the top and later ones at the bottom

image

If this sounds good, we'll need an engineer who can implement it.

Yes! I was reading this issue and looking at the original idea and thinking this exact same thing.

@peterrowland
Copy link
Member

peterrowland commented Oct 4, 2024

I have a PR open for this that only reverses the sort order and bolds the current week.

While it would be possible to implement the proposed design with a separate list for the current week, it doesn't account for overdue items

I attempted to create a version with an additional list for overdue items if there are any, but realized it requires a redesign to toggle whether lists are visible and append items to them. I don't think this can be accomplished with the inline scripting language.

The two options I see without doing that are use this simplified version that I've made, or create a separate list for the current week and accept that overdue items will appear out of order under the 'upcoming weeks' list.

@cantsin
Copy link
Member

cantsin commented Oct 4, 2024

Thanks all. We'll go with a simpler solution for now and iterate. Closing, but will re-open if we need further improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants