LG-15204 | Guard against NoMethodError when ZIP is null #11567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There may be a deeper error, but let's at least stop raising exceptions for now. changelog: Internal, Bug Fixes, InstantVerify requests no longer raise an exception when ZIP code is nil
spec/services/proofing/lexis_nexis/instant_verify/verification_request_spec.rb
Outdated
Show resolved
Hide resolved
spec/services/proofing/lexis_nexis/instant_verify/verification_request_spec.rb
Outdated
Show resolved
Hide resolved
I had two errors masking each other. D'oh!
zachmargolis
approved these changes
Nov 26, 2024
|
What does Instant Verify do if we don't pass a zip? I do want to make sure we have a way of tracking how often this is happening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15204
🛠 Summary of changes
There may be a deeper error, but let's at least stop raising exceptions for now.
changelog: Internal, Bug Fixes, InstantVerify requests no longer raise an exception when ZIP code is nil